Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix failing opentelemetry unit test #6927

Merged
merged 2 commits into from
Dec 9, 2024
Merged

🐛 Fix failing opentelemetry unit test #6927

merged 2 commits into from
Dec 9, 2024

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review December 9, 2024 15:47
@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 9, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Dec 9, 2024
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 9, 2024 15:49
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.55%. Comparing base (bf06671) to head (215b3a4).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6927      +/-   ##
==========================================
- Coverage   86.93%   82.55%   -4.38%     
==========================================
  Files        1571      625     -946     
  Lines       61647    30437   -31210     
  Branches     2000      262    -1738     
==========================================
- Hits        53590    25126   -28464     
+ Misses       7735     5251    -2484     
+ Partials      322       60     -262
Flag Coverage Δ
integrationtests 65.02% <ø> (+6.89%) ⬆️
unittests 86.80% <ø> (+0.26%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (+11.72%) ⬆️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.78% <ø> (-5.94%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.30% <ø> (+0.35%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf06671...215b3a4. Read the comment docs.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit ed17770 into ITISFoundation:master Dec 9, 2024
89 of 93 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 10, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels
None yet
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
5 participants
@matusdrobuliak66 @giancarloromeo @pcrespov @odeimaiz @sanderegg